search

MasterKale / SimpleWebAuthn

WebAuthn, Simplified. A collection of TypeScript-first libraries for simpler WebAuthn integration. Supports modern browsers, Node, Deno, and more.
https://simplewebauthn.dev
MIT License
1.63k stars 137 forks source link

`devicePublicKey` => `devicePubKey` #243

Closed agektmr closed 2 years ago

agektmr commented 2 years ago

Trivial update aligning the extension name to the spec.

MasterKale commented 2 years ago

Hmm, there are a few unit tests that continue to reference the now "old" value devicePublicKey:

Screen Shot 2022-08-09 at 9 10 50 AM

Can you update these tests so everything refers to this extension as devicePubKey as well?

agektmr commented 2 years ago

Sorry, I overlooked your comment. Will fix them.

agektmr commented 2 years ago

@MasterKale Updated the tests. Can you check?

MasterKale commented 2 years ago

lgtm :shipit:

MasterKale commented 2 years ago

There's no issue associated with this so I'll let you know here that this is now available in @simplewebauthn/server@5.4.5.