Closed unix closed 1 year ago
Thank you for the PR, @unix. Can you please add some tests? If you rebase off of master you shouldn't have any issues running server's tests locally now.
@MasterKale
I rebase to the latest code (from master
), but I can hardly run all the test cases, which contain a lot of type errors. It seems that the coupling between the organization of the project and the monorepo is a little strange.
I am not sure if the try catch
will affect the original test cases (it may not seem like it), but I am unable to run existing test cases correctly, making it even more difficult to add test cases. It would be very helpful if you could take over this PR.
@MasterKale we have this issue too. could you please look into this PR? thanks
I'm going to find time this week to take this work over.
Thank you again for your contribution @unix. I gave you a shout-out in #443 as it's pretty much this PR but with tests, so I'm marking this one as superseded by the new PR. Thanks for understanding ✌️
Changes
Methods
getPublicKey
andgetPublicKeyAlgorithm
may still returnfunction type
in unsupported environments and only throw an error when called, for this reason we manually ignore this error.Refs
438