MasterKale / SimpleWebAuthn

WebAuthn, Simplified. A collection of TypeScript-first libraries for simpler WebAuthn integration. Supports modern browsers, Node, Deno, and more.
https://simplewebauthn.dev
MIT License
1.62k stars 137 forks source link

fix/513-cbor-x-type-issues #521

Closed MasterKale closed 9 months ago

MasterKale commented 9 months ago

This PR replaces use of the cbor-x dependency with tiny-cbor. The use of cbor-x/index-no-eval caused issues with transpiling typical Node-centric use of SimpleWebAuthn because TypeScript couldn't find types for index-no-eval due to the project's architecture.

No reasonable workaround within SimpleWebAuthn could be determined so I have decided to move to the excellent tiny-cbor instead. This library supports the right amount of CBOR to work with WebAuthn responses, and also cross-publishes on https://deno.land/x and NPM, so it'll be a great replacement.

Addresses #513.

LeviSchuck commented 9 months ago

Looks correct to me