search

MasterKale / SimpleWebAuthn

WebAuthn, Simplified. A collection of TypeScript-first libraries for simpler WebAuthn integration. Supports modern browsers, Node, Deno, and more.
https://simplewebauthn.dev
MIT License
1.62k stars 137 forks source link

fix(browser): handle undefined PublicKeyCredential in browserSupportsWebAuthnAutofill helper #545

Closed clarafitzgerald closed 7 months ago

clarafitzgerald commented 7 months ago

This PR adds an early return to the browserSupportsWebAuthnAutofill helper function if browserSupportsWebAuthn returns false. This prevents browserSupportsWebAuthnAutofill from throwing a TypeError on browsers without webauthn support.

Closes #544

MasterKale commented 7 months ago

Thank you for the PR @clarafitzgerald, but as per the README's Contributions section this project is not currently accepting external contributions.

I still appreciate you taking the time to submit #544, which helped me quickly complete #557 to address the issue (along with getting some testing on this method.) Thank you for understanding 🙇

MasterKale commented 7 months ago

Wait a minute, I left the door open for external contributions for bug fixes 🤦‍♂️

Screenshot 2024-04-12 at 2 17 26 PM

I'm really sorry about that @clarafitzgerald, I forgot about that exception. I'll still give you credit in the release notes because this PR definitely qualified as a bugfix...sorry again 🫠