stats: Add restarts, total words, total chars to the result

MasterMedo / typetest

:chart_with_upwards_trend: Improve your typing speed without leaving the terminal.

MIT License

24 stars 8 forks source link

stats: Add restarts, total words, total chars to the result #21

Closed s-surineni closed 3 years ago

s-surineni commented 3 years ago

Adding new results upon successful finish of a test!

[x] My PR has been linted with flake8, i.e. poetry run flake8
[x] My PR has been formatted with black, i.e. poetry run black .

s-surineni commented 3 years ago

Closes #6

s-surineni commented 3 years ago

@MasterMedo I was able to add results like restart, words typed, characters typed. I am unable to find out the keyboard layout through python. Please let me know if you are aware of a method

MasterMedo commented 3 years ago

Hey there, thanks for the contribution 🎉

I like the implementation of restarts, simple, readable and short. 😇 The total characters and words idea reminds of the kind of results you get from 10fastfingers and monkeytype. Instead of printing out the number of total words or characters we can print this new format: f'keystrokes: {correct_chars} correct | {total_chars - correct_chars} incorrect'.

s-surineni commented 3 years ago

@MasterMedo Thanks for the review. I've committed the changes you suggested.

MasterMedo commented 3 years ago

This has been a lovely conversation. Thanks for the contribution once again! 🥂

s-surineni commented 3 years ago

Thanks, @MasterMedo, I enjoyed working on the task. Can you please add the label hacktoberfest-accepted to the PR

MasterMedo commented 3 years ago

I can, but I don't have to. Your contribution counts once a PR is approved or accepted or a label is added. You can check your contributions here hacktoberfest-checker. As far as I can see, this contribution is counted. The reason it says "in progress", and not "completed" is because of a 14 days cooldown which gives the Hacktoberfest organisators the time to check out the quality of the PRs.