Implement: plot_wpm_by_test_duration

MasterMedo / typetest

:chart_with_upwards_trend: Improve your typing speed without leaving the terminal.

MIT License

24 stars 8 forks source link

Implement: plot_wpm_by_test_duration #30

Closed basil08 closed 3 years ago

basil08 commented 3 years ago

Others:

fix: 9+ lint issues in analyse.py
add: .vscode basic linting settings.json
modify: .gitignore to add venv/

This PR addresses issue #4 and implements a plot function to plot typing speeds based on time interval buckets (4 buckets).

Please complete these tasks before opening your PR:

[X] My PR has been linted with flake8, i.e. poetry run flake8
[X] My PR has been formatted with black, i.e. poetry run black .
[X] My PR passes the tests, i.e. poetry run python -m unittest

basil08 commented 3 years ago

Hey @MasterMedo, check out this function. Let me know if you want any changes. The conflicts are mostly lint issues fixed so shouldn't be much of a problem. :)

MasterMedo commented 3 years ago

Hey there! Thanks for making the effort to contribute 🎉

I will check this out today. Can you please merge the main branch here, and run black again? I see some obvious mistakes with the linting of this branch.

On the other note, can you add all pyenv, vscode and similar things to the .gitignore? Some files submitted don't quite fit into here 😅

MasterMedo commented 3 years ago

Usually, you don't have to start from scratch (I see you forked one more time 💪).

If you need any help with git or have any other questions please feel free to ask them, I'd be happy to help. n_n