Closed basil08 closed 3 years ago
Hi there,
Please don't open multiple pull requests for the same problem.
The last branch #30 was closed unnecessarily.
Usually, you want to keep the branch and commit to the same pull request so that we don't lose the discussion context.
If the master (main) branch changes in the mean time, the course of action is to git merge
the upstream into your pull request branch.
The formatting and linting issues are happening because your editor configuration differs from the project settings. Namely, our black
formatter has the line length set to 79 characters and takes precedence over flake8
.
Otherwise, everything else seems in order 😄 I'll run the program now and see how it looks. 💪
I took the liberty to reorganise a bit, I hope you don't mind. 😅
Thanks for making this contribution, here's a medal: 🎖️
I have an idea for improving this function. Instead of having tests with fixed duration categories, I was thinking we could try to infer the most sensible durations from the results recorded. For example, if the person runs many tests around 30 seconds long with low variance, we can infer that the person aims their tests to be 30 seconds long so we can create a category "30 second tests". The other tests seem to be longer than 1 minute, but the variance is high so we bucket them all in one bucket "tests over 1 minute". I'll think a bit over the next week how to approach this, but I think it would be a fun little project to make if you want to try it. n_n
Others:
This PR intends to close #4 by implementing the said function.
Please complete these tasks before opening your PR:
poetry run flake8
poetry run black .
poetry run python -m unittest