MasterVitronic / fusionpbx

Automatically exported from code.google.com/p/fusionpbx
0 stars 0 forks source link

Use session:preAnswer() instead of session:answer in hunt groups. #160

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Is there any reason not to use session:preAnswer instead?  It seems that it 
makes the most sense to send the progress tones as 183 w/ SDP instead of 200 OK 
with SDP.

The simple patch provides the desired behavior.

--- 
fusionpbx-2.0.9-20110824svn.orig/fusionpbx/includes/lib_switch.php  2011-08-24 
11:20:12.000000000 -0700
+++ fusionpbx-2.0.9-20110824svn/fusionpbx/includes/lib_switch.php   2011-08-24 
13:53:15.190546061 -0700
@@ -2804,7 +2804,7 @@ function sync_package_v_hunt_group() {
                //get the list of destinations then build the Hunt Group Lua
                    $tmp = "";
                    $tmp .= "\n";
-                   $tmp .= "session:answer();\n";
+                   $tmp .= "session:preAnswer();\n";
                    $tmp .= "extension = '".$row['huntgroupextension']."';\n";
                    $tmp .= "result = '';\n";
                    $tmp .= "timeoutpin = 7500;\n";

Original issue reported on code.google.com by sjthomas...@gmail.com on 24 Aug 2011 at 9:04

GoogleCodeExporter commented 9 years ago
Also, instead of transferring to *99 to timeout to voicemail, should the 
voicemail app be called directly?

I have attached a patch that includes both of these changes.

Original comment by sjthomas...@gmail.com on 26 Aug 2011 at 9:20

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks for the suggestions. Committed in revision 1500.

Original comment by markjcrane@gmail.com on 27 Aug 2011 at 7:36