Closed jgrumboe closed 1 year ago
@DRuggeri Is this PR ok? Is the test sufficient?
If it's fine I could also "extend" this PR to solve #124 and add update_data
in the same way.
It would be awesome to have the same feature for update and delete.
@m-garrido @melt-melt
I also added support for update_data
.
@DRuggeri can you have a look at this?
@DRuggeri I needed to update the GH release action also following this comment https://github.com/hashicorp/ghaction-import-gpg/issues/11#issuecomment-1185107410 Otherwise I wasn't able to publish the provider interim to my personal TF registry account.
I can remove the commit before merging.
@m-garrido @melt-melt
~~I published my changes interim to TF registry under https://registry.terraform.io/providers/jgrumboe/restapi/1.18.0-dev
You could try out update_data
and destroy_data
for tests, would like to remove the provider from my account in the TF registry after this PR is merged.~~
Update: This PR is already merged, please use the official version >= 1.18.0!
@DRuggeri can you help me here to get that merged? If something is missing like tests or docs, just tell me. Thanks in advance 🙏
@douernesto @Martina-May Could you probably help in getting this PR merged? Unfortunately there's no feedback yet from @DRuggeri 😞
Hello, I am also waiting for this feature. Would be nice to have it released soon.
Many apologies for the delay responding to this PR. This seems to make a lot of sense and I've added a quick few notes. If you can address those, we can go ahead and merge and cut a new release with this!
@DRuggeri Thanks for the feedback. I addressed it.
This PR is inspired by #177 and it adds one feature:
It could solve #174 I think.