Mastercard / terraform-provider-restapi

A terraform provider to manage objects in a RESTful API
Other
808 stars 217 forks source link

Add support for destroy_data and update_data to be sent #182

Closed jgrumboe closed 1 year ago

jgrumboe commented 2 years ago

This PR is inspired by #177 and it adds one feature:

It could solve #174 I think.

jgrumboe commented 2 years ago

@DRuggeri Is this PR ok? Is the test sufficient?

If it's fine I could also "extend" this PR to solve #124 and add update_data in the same way.

m-garrido commented 2 years ago

It would be awesome to have the same feature for update and delete.

jgrumboe commented 2 years ago

@m-garrido @melt-melt I also added support for update_data. @DRuggeri can you have a look at this?

jgrumboe commented 2 years ago

@DRuggeri I needed to update the GH release action also following this comment https://github.com/hashicorp/ghaction-import-gpg/issues/11#issuecomment-1185107410 Otherwise I wasn't able to publish the provider interim to my personal TF registry account.

I can remove the commit before merging.

jgrumboe commented 2 years ago

@m-garrido @melt-melt ~~I published my changes interim to TF registry under https://registry.terraform.io/providers/jgrumboe/restapi/1.18.0-dev You could try out update_data and destroy_data for tests, would like to remove the provider from my account in the TF registry after this PR is merged.~~

Update: This PR is already merged, please use the official version >= 1.18.0!

jgrumboe commented 2 years ago

@DRuggeri can you help me here to get that merged? If something is missing like tests or docs, just tell me. Thanks in advance 🙏

jgrumboe commented 1 year ago

@douernesto @Martina-May Could you probably help in getting this PR merged? Unfortunately there's no feedback yet from @DRuggeri 😞

Sh1ftry commented 1 year ago

Hello, I am also waiting for this feature. Would be nice to have it released soon.

DRuggeri commented 1 year ago

Many apologies for the delay responding to this PR. This seems to make a lot of sense and I've added a quick few notes. If you can address those, we can go ahead and merge and cut a new release with this!

jgrumboe commented 1 year ago

@DRuggeri Thanks for the feedback. I addressed it.