MasteringOpenCV / code

Code for the book "Mastering OpenCV with Practical Computer Vision Projects" by Packt Publishing 2012.
Other
2.72k stars 1.64k forks source link

Chapter 4: is the iterative triangulation code correct? #40

Closed aledalgrande closed 10 years ago

aledalgrande commented 10 years ago

I'm trying to get my head around this: https://github.com/MasteringOpenCV/code/blob/master/Chapter4_StructureFromMotion/Triangulation.cpp#L77

Mat_<double> X_ = LinearLSTriangulation(u,P,u1,P1);

Inside the loop, none of u, P, u1, P1 are changed. Wouldn't that reset the result every time?

aledalgrande commented 10 years ago

It's just wrong.