Masterminds / glide

Package Management for Golang
https://glide.sh
Other
8.16k stars 539 forks source link

fix: git submodule foreach command accept one argument. #1059

Closed tangxinfa closed 4 years ago

tangxinfa commented 5 years ago

glide update failed on my project after upgrade git to 2.22.0.

glide debug output:

error: unknown switch `x'
usage: git submodule--helper foreach [--quiet] [--recursive] [--] <command>

    -q, --quiet           Suppress output of entering each submodule command
    --recursive           Recurse into nested submodules

fatal: run_command returned non-zero status while recursing in the nested submodules of proto

git submodule foreach --recursive command accept one argument now.

See similar merge request https://github.com/golang/dep/pull/2168/files for more information.

mattfarina commented 4 years ago

@tangxinfa Thanks for the PR. The upstream dependency needed to be fixed instead of patching it here. That happened yesterday and a new release with a fix will come out soon.