search

Masterminds / glide

Package Management for Golang
https://glide.sh
Other
8.15k stars 540 forks source link

Add option to strip *_test.go: --strip-test -t #422

Open aeneasr opened 8 years ago

aeneasr commented 8 years ago

Issue discussed in the Go repository: https://github.com/golang/go/issues/14417
Godep issue: https://github.com/tools/godep/issues/427

aeneasr commented 8 years ago

Better: Make the option true by default when running > Go 1.6 or GO15VENDOREXPERIMENT

--skip-strip-tests

sdboyer commented 8 years ago

IIRC, @mattfarina had some concerns about the licensing implications of stripping out source files. Not sure if it extended to test files, though.

Absent licensing issues, I'm +1 to this being an option. Actually, I'd argue it should be an opt in the manifest, not a CLI opt, b/c that way the behavior will be invariant across all users of the project. It's a nasty gotcha to require users to make a workflow change for this or that project when it can easily be avoided.

aeneasr commented 8 years ago

Absent licensing issues, I'm +1 to this being an option. Actually, I'd argue it should be an opt in the manifest, not a CLI opt, b/c that way the behavior will be invariant across all users of the project. It's a nasty gotcha to require users to make a workflow change for this or that project when it can easily be avoided.

I second that.

nikhiljindal commented 7 years ago

Came here looking for this exact feature. There seems to be a PR for this: https://github.com/Masterminds/glide/pull/869 (last updated in July)

mattfarina commented 7 years ago

First, if you can you should try switching to dep.

Second, There's a plugin for what you're looking for in https://github.com/sgotti/glide-vc.