search

Masterminds / glide

Package Management for Golang
https://glide.sh
Other
8.15k stars 540 forks source link

Proposal: Drop subpackages from glide.yaml file #430

Open mattfarina opened 8 years ago

mattfarina commented 8 years ago

This idea is to remove the record from the glide.yaml file while keeping the record in the glide.lock file.

The subpackages from the glide.yaml used to be used as part of the rebuild command for the setup prior to the GO15VENDOREXPERIMENT. That command is no longer needed (instead go install should be used).

Thoughts @technosophos?

xeger commented 8 years ago

The problem with go install is that I can't version a code-gen tool binary (goagen) alongside a vendored library dependency (goa). Makes things a bit difficult to work with. Is there a best practice for this + glide?

elan100cs commented 7 years ago

One possible use case of specifying subpackage is when we want to force to pull the dependency of that subpackage. This is useful when a project define 1 repository for all of it's common library, which doesnt guarantee for all of the subpackages gets imported within the root packages.

Since now, the way to use glide is to specify it's root package, i find that if we dont have any imports of the subpackage within the root package, the dependencies of the subpackage doesnt gets fetch automatically, though i thought the old version of glide does this automatically.

Can we use subpackage to fulfill this use case? Or does it already being handled by some other features in glide ?

sdboyer commented 7 years ago

@elan100cs it's an important case, and not currently handled by anything else. But, we're planning an orthogonal config option for the next major release that covers it. so, still no need to keep these around :)