search

Masterminds / glide

Package Management for Golang
https://glide.sh
Other
8.15k stars 541 forks source link

Handle error in Godep strip WalkFunc #990

Closed tonyghita closed 5 years ago

tonyghita commented 6 years ago

It seems like filepath.Walk has changed in Go1.10 in some way. When an error is present, info is nil.

Fixes #975.

vkamra commented 6 years ago

@mattfarina - this is similar to your fix #953 - in the godep code path. Can we get this in? Hitting this with Go 1.10

danwinship commented 6 years ago

While this patch works around the crash and is correct anyway, the real fix is to return filepath.SkipDir rather than nil if we call os.RemoveAll() later in the function (like in #956, although that also included a bunch of other refactoring)

fxcoudert commented 6 years ago

Can this fix (or an equivalent fix) please be merged, and a new release tagged? This is impacting distributors like Homebrew who ship go software.

bacongobbler commented 6 years ago

https://github.com/Masterminds/glide/releases/tag/v0.13.2 was released yesterday with a bugfix for this particular issue. This stack trace in particular was fixed for Helm, so it's likely fixed for other projects. This PR may be defunct in that case and should probably be closed.

danwinship commented 6 years ago

0.13.2 includes #956, which fixes the crash when skipping vendor/ but not when skipping Godeps/_workspace/

danwinship commented 5 years ago

1033 has the correct fix. This should be closed.

tonyghita commented 5 years ago

Closing in favor of #1033