Allow to pass a charset to the Scanner

Masterminds / html5-php

An HTML5 parser and serializer for PHP.

http://masterminds.github.io/html5-php/

Other

1.59k stars 114 forks source link

Closed tgalopin closed 5 years ago

tgalopin commented 5 years ago

Also fixes a few comments indentation.

goetas commented 5 years ago

Hi, instead of adding a new parameter, why not add an option to the option array? It will be consistent with the rest of the public api

tgalopin commented 5 years ago

Okay, no problem :) .

goetas commented 5 years ago

@tgalopin let me know when this is done, so i can create a new release with the recent performance improvements

tgalopin commented 5 years ago

Sorry, working on it, the SymfonyCon Lisbon was tiring :) .

tgalopin commented 5 years ago

Done :) !

tgalopin commented 5 years ago

I didn't change this, I just expanded the conditionnals using only ifs instead of elseifs :) .

goetas commented 5 years ago

Right! I should stop making code reviews using the phone! :smile:

goetas commented 5 years ago

Can you add some tests for this feature?

tgalopin commented 5 years ago

I added tests :) .

goetas commented 5 years ago

hmm, it looks something did not work

tgalopin commented 5 years ago

I updated the tests :) .

EDIT: and they still fail ... :D working on it.

tgalopin commented 5 years ago

Done \o/

tgalopin commented 5 years ago

I think this is ready for review :)!

goetas commented 5 years ago

Thanks!

goetas commented 5 years ago

Do you need a tag for it or can wait?

tgalopin commented 5 years ago

A tag would be nice, but it can wait a few days/weeks if needed :) .

goetas commented 5 years ago

released as 2.6.0