search

Masterminds / html5-php

An HTML5 parser and serializer for PHP.
http://masterminds.github.io/html5-php/
Other
1.56k stars 115 forks source link

mitigate cyclic reference between output rules and the traverser objects #190

Closed goetas closed 4 years ago

goetas commented 4 years ago

Alternative implementation of https://github.com/Masterminds/html5-php/pull/188

it is substantially the same but using a separate method in the concrete class...

closes https://github.com/Masterminds/html5-php/pull/188

lyrixx commented 4 years ago

Yes, it's much better (no BC / more doc) Thanks for taking care of it. I was a bit busy yesterday - I had to prepare a talk I gave this morning :)

goetas commented 4 years ago

Alright! Thanks for digging that deep into this memory issue @lyrixx!