search

Masterminds / html5-php

An HTML5 parser and serializer for PHP.
http://masterminds.github.io/html5-php/
Other
1.55k stars 114 forks source link

Fix minor version #202

Closed PuneetGopinath closed 3 years ago

PuneetGopinath commented 3 years ago

Hi html5-php Maintainers

I fixed minor version in installation section for adding as dependency in composer.json

PuneetGopinath commented 3 years ago

Useless repo, 1 month over Did you ever reply, or at least close this pr.

mundschenk-at commented 3 years ago

I'm not the maintainer, but you gave no reason why that change would be beneficial. What does changing the minor version actually accomplish? It will install the same library version due to the ^ operator.

PuneetGopinath commented 3 years ago

No, it will install 2.7.x instead of 2.0.x And x is the latest patch version of the minor version

PuneetGopinath commented 3 years ago

See https://getcomposer.org/doc/articles/versions.md#caret-version-range-

treats ^0.3 as >=0.3.0 <0.4.0

It means that it treats ^2.0 as >=2.0.0 <2.1.0

mundschenk-at commented 3 years ago

See https://getcomposer.org/doc/articles/versions.md#caret-version-range-

treats ^0.3 as >=0.3.0 <0.4.0

It means that it treats ^2.0 as >=2.0.0 <2.1.0

That's a misleading partial quote, as the sentence starts with "For pre-1.0 versions it also acts with safety in mind and".

PuneetGopinath commented 3 years ago

Ohh, ok

mundschenk-at commented 3 years ago

No, it will install 2.7.x instead of 2.0.x And x is the latest patch version of the minor version

This is not true. It will install the latest release of the same semver major version number.

mundschenk-at commented 3 years ago

I don't know why you will or will not trust "us" (as I said, I'm not a maintainer), but if you propose a PR, you should argue why it is necessary and beneficial.

We are all in the middle for a pandemic, so a PR without a preexisting issue and no compelling reasoning will probably not get much brain bandwidth?