search

Masterminds / html5-php

An HTML5 parser and serializer for PHP.
http://masterminds.github.io/html5-php/
Other
1.55k stars 114 forks source link

$tok might be false in Tokenizer.php #221

Closed sakarikl closed 1 year ago

sakarikl commented 1 year ago

ctype_alpha(false) triggers warning ctype_alpha(): Argument of type bool will be interpreted as string in the future

stof commented 1 year ago

It would be great to have a test preventing regressions

heikokrebs commented 1 year ago

Some warning for the ctype_alpha() call in the endTag() function.

ctype_alpha(): Argument of type bool will be interpreted as string in the future in vendor/masterminds/html5/src/HTML5/Parser/Tokenizer.php on line 350

Anything we can do here?

goetas commented 1 year ago

@heikokrebs maybe you can provide a test case for this?

goetas commented 1 year ago

merging it anyway, thanks

heikokrebs commented 1 year ago

merging it anyway, thanks

Thanks a lot!