search

Mastermindzh / tidal-hifi

The web version of Tidal running in electron with hifi support thanks to widevine.
Other
1.01k stars 56 forks source link

Fix instructions for building from source #365

Closed ungive closed 6 months ago

ungive commented 6 months ago

Add npm run build command

sonarcloud[bot] commented 6 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Mastermindzh commented 6 months ago

Hey @jonasberge,

The idea is great but unfortunately the instructions in your PR are wrong. (which I reckon is proof enough that this needs updating). I will be releasing a new version of TIDAL later today and will include the correct instructions.

ungive commented 6 months ago

Hey @Mastermindzh,

npm watchStart in your commit fd0dae2 is incorrect, it yields Unknown command: "watchStart". It should be npm run watchStart

Also with the new instructions it's still a little unclear to me that, to simply run tidal-hifi, you have to do npm run compile before running npm start. But that might be just me.

Thanks for updating the instructions!