Closed TheRockYT closed 2 months ago
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
No data about Duplication
Hey @TheRockYT,
Thanks for the PR, initial code looks good. I'm able to test it during the weekend (probably) and based on that we can continue with either a merge or maybe some more bugfixing.
Multiple TIDAL windows and not "correctly" handling the protocol doesn't really matter to me, kinda weird to have 2 open anyway as you already point out. I mean... I'll have a little look at it, but probably fine.
PR for issue #138 (tidal:// protocol)
The custom protocol ('tidal://...') wasn't working correctly:
What I've changed
What could be improved
How to test
To test the custom protocol, the app needs to be installed locally (deb, rpm, ...) and run at least one time.
For example, to build a deb just run
npm run build-deb
and install withsudo apt reinstall ./dist/tidal-hifi_*.deb
Important: The
electron
test command does not let the registration of custom protocols happen.Then, go to an artist, playlist or album page on the TIDAL web-page (not web-player) and click "Open in Desktop App".
Example TIDAL web-page links:
I did not test this on other devices then on an Ubuntu-Desktop and a Fedora-Laptop, so please report issues with them.