Mastermindzh / tidal-hifi

The web version of Tidal running in electron with hifi support thanks to widevine.

Other

1.07k stars 61 forks source link

Window isn't rendered at desktop resolution #468

Open kbasaran opened 3 months ago

kbasaran commented 3 months ago

Hello,

I use 200% display scaling on my screen and I see that Tidal window is not rendered at the correct resolution. I add a screenshot to show the difference in sharpness with Firefox.

Screenshot from 2024-08-31 08-32-29

Ubuntu 24.04.1 LTS deb package, manually installed, tidal-hifi/now 5.16.0 amd64

Mastermindzh commented 3 months ago

Make sure you are using the following flags: --enable-features=UseOzonePlatform --ozone-platform=wayland Also see: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1318, it's a known issue in Electron unfortunately.

lrpg commented 2 months ago

No request here, just stating if that can be of some help to someone.

As far as I remember, it was clear at 4k without fractional scaling under Ubuntu 22 (last week in my case).
It's now clear at 4k ONLY with fractional scaling under Ubuntu 24. Aka, it's now blurry without the fractional scaling. Above flags aren't changing the result.

Ubuntu 24.04.1 flatpak installed. Tried w/ and w/o --enable-features=UseOzonePlatform --ozone-platform=wayland flags.

Something is probably different for Wayland under Ubuntu 24. Haven't dug at all to find what. or Maybe it wasn't running under Wayland at all for some reason.

kbasaran commented 2 months ago

Make sure you are using the following flags: --enable-features=UseOzonePlatform --ozone-platform=wayland Also see: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1318, it's a known issue in Electron unfortunately.

Isn't that already done by this commit though? I'm running the desktop file to start the app.

Same comments for #467, since these flags are the proposed solution also there.

Mastermindzh commented 2 months ago

476 is not running the desktop file 😄.

But yes, if you use the Wayland platform flags then it "should" support fractional scaling, but it's always given me issues with Electron apps t.b.h (unless the app specifically supports it by using proper css scaling like rems instead of pixels)