search

MastersAcademy / frontend-course-2021

Репозиторій з курсу «Advanced Front-end» проекту Masters Academy
MIT License
5 stars 29 forks source link

9 animations #245

Closed MaksymSelenkov closed 2 years ago

MaksymSelenkov commented 2 years ago

https://maksymselenkov.github.io/frontend-course-2021/homeworks/maksym.selenkov_MaksymSelenkov/9-animations/index.html

DrSmile444 commented 2 years ago

One more thing: Please, review how your site is responsive. It displays wrong on 1024px, so I didn't check fewer sizes.

maksymselenkov github io_frontend-course-2021_homeworks_maksym selenkov_MaksymSelenkov_9-animations_index html (1)

DrSmile444 commented 2 years ago

And one more: You don't have SVG animation on the site load, as is mentioned in the task:

When the page is loaded, the svg logo must be animated once

MaksymSelenkov commented 2 years ago

I have SVG animation in CSS and seems it works or I should add it by window.onload in JS?

As for BEM classes: I write 2 classes when I want to make a block from the element: "pagesection section" to use further "sectiontitle", "section__content". In this case I have to remove one of them?

DrSmile444 commented 2 years ago

I have SVG animation in CSS and seems it works or I should add it by window.onload in JS?

Oh, I fount the animation, my bad, sorry). I just thought it would be like loader, but not a problem.

As for BEM classes: I write 2 classes when I want to make a block from the element: "pagesection section" to use further "sectiontitle", "section__content". In this case I have to remove one of them?

I got the point. So let's keep it as it is.

PS: Still, responsive for iPad looks bad. Could you double-check it, please?

image