Masterworks / Clarity-Components

0 stars 1 forks source link

Add New User #19

Closed devfreddy closed 6 years ago

devfreddy commented 6 years ago

@danielgolden For our Administration screens, on List Users we have an "Add New User" button, but I do not see a screen for that.

Was it your intention that it be the same as Edit User?

Working off of that assumption we can re-use most of Edit User, but it may still be good to call it out and have it as it's own screen in Invision. What do you think?

danielgolden commented 6 years ago

Wow, you're right. That's a really good point, and I agree we should have a specific screen to clear up any ambiguity about the screen. I'll design it, add it to InVision and post it here when it's ready.

danielgolden commented 6 years ago

@mdfrederick I'm also realizing that we probably need something similar for "edit client", so I'm going to go ahead and add that to InVision too. Will will need the same for "New Role" and "New Permission Set" too?

danielgolden commented 6 years ago

✅ I've uploaded a New User screen to InVision (as well as a New Client screen). When the "client" field for a new user is filled out, then the "Client Permissions" section should be displayed, but up until then it should be hidden.

devfreddy commented 6 years ago

@danielgolden Yes, we need something for New Role and New Capability (Permission) Set as well, not a priority though. The pages actually already exist and function on the site using some default markup.

I think "Selects Clients" can just be "Clients" or if you want consistency with the other items "Edit Clients". Selects is too specific, Clients will be used across the board (with other apps). Was it like that before and I missed it?

New User Screen

Let's tweak the workflow a bit. Instead of hidden, let's just omit Client Permissions. When you've saved (i.e. created) the User, we will redirect you to the "Edit User" screen. Keeps this simpler, reuses what's on the Edit screen.

We can change Client(s) to Primary Client, singular. Most new accounts from here on out should be actual employees of our Clients and they will only have access to one Client. This matches a requirement change we received at some point when we added a "Primary Client" field to the API.

danielgolden commented 6 years ago

Selects is too specific, Clients will be used across the board (with other apps). Was it like that before and I missed it?

Not sure how that title made it this far because your comment makes a lot of sense. Guess we both missed it. This sounds good.

Instead of hidden, let's just omit Client Permissions. When you've saved (i.e. created) the User, we will redirect you to the "Edit User" screen. Keeps this simpler, reuses what's on the Edit screen.

Cool, I like this a lot. I've also made the primary client label changes to the InVision screen.

devfreddy commented 6 years ago

I've also made the primary client label changes to the InVision screen.

I'm not actually seeing this. Invision caching issue?

https://www.dropbox.com/s/pvk11b7k73h36n1/Screenshot%202018-07-30%2010.40.18.png?dl=0

danielgolden commented 6 years ago

Not sure what I did or thought I did, but I can't even see my changes. Updating them now...

danielgolden commented 6 years ago

Ok, now I've actually updated both.

I'm not sure what to do about the client permissions section on the edit user screen, because even though this example user doesn't have access to multiple clients, it's still possible that a user could have access to multiple clients, right? I'm afraid that If I remove the multiple clients listing and toggle functionality that it will be forgotten when implemented.

Not sure if that makes sense, but in short, let me know if I should remove the remaining 3 clients from the client permissions section in the edit client screen.

devfreddy commented 6 years ago

I'm not sure what to do about the client permissions section on the edit user screen, because even though this example user doesn't have access to multiple clients, it's still possible that a user could have access to multiple clients, right? I'm afraid that If I remove the multiple clients listing and toggle functionality that it will be forgotten when implemented.

I think on the Edit User screen we can leave it the way it is, we don't need to remove it. Regardless of what they do/don't have access to, we're going to show all the Clients so we can toggle their access on/off. I just didn't want it on the New User screen.

Chitradip-Capitalnumbers commented 6 years ago

@mdfrederick I have added this template. Which you posted in clarity-app - Admin Users - New User #85. Please check that.

Thanks!