search

MastodonC / kixi.stats

A library of statistical distribution sampling and transducing functions
https://cljdoc.xyz/d/kixi/stats
Eclipse Public License 1.0
355 stars 17 forks source link

Is incanter necessary? #17

Closed plexus closed 5 years ago

plexus commented 5 years ago

kixi.stats has a :dev dependency on Incanter, however through transitive dependencies Incanter relies on a version of bouncycastle that no longer exists on Maven (see https://github.com/incanter/incanter/issues/388)

This causes issues under Clojure CLI, e.g. here you can see that Cljdoc is unable to build the docs for kixi.stats 0.4.1

https://circleci.com/gh/martinklepsch/cljdoc-builder/3024

This is partly a problem with cljdoc I think, Incanter has <scope>test</scope> in the kixi.stats pom, so it should probably ignore it

curl https://repo.clojars.org/kixi/stats/0.4.1/stats-0.4.1.pom

However doing a quick grep it seems incanter isn't actually used anywhere in the kixi.stats codebase. Is it necessary to have it in there?

henrygarner commented 5 years ago

@plexus thanks for the report. IIRC Incanter is left over from when I performed spot checks against various distributions. I’m pretty sure it can safely be removed though I won’t know for sure until I’m back at my desk later today

plexus commented 5 years ago

It can surely wait until then :) thanks for the quick response!

henrygarner commented 5 years ago

Incanter dependency has been removed in 0.4.2

martinklepsch commented 5 years ago

Docs for kixi.stats are now available on cljdoc: https://cljdoc.xyz/d/kixi/stats/0.4.2 🙂

henrygarner commented 5 years ago

@martinklepsch Excellent thanks! 🎉 Though makes me realise a local uncommitted file has made it into the Clojars artefact: https://cljdoc.xyz/d/kixi/stats/0.4.2/api/kixi.stats.params#Params 🤭