search

MatAtBread / fast-async

605 stars 21 forks source link

Fix plugin for Babel v7 beta. #51

Closed phyllisstein closed 6 years ago

phyllisstein commented 6 years ago

Uses the new Babel module imports helper to require the runtime package when useRuntimeModule is set. I've verified in a couple of my own projects that this fixes the plugin for the Babel v7 beta, and as the benchmarks still run I believe it should be backwards-compatible with v6 as well.

matAtWork commented 6 years ago

LGTM. Published as fast-async@6.3.1

Thanks for the PR. If you're interested, https://github.com/babel/babel/pull/7076 is a PR that moves the core transform into Babel7. TBH, I don't really have the time to polish it as much as the Babel guys would like, but if you do and you're interested in use the nodent transform from within Babel7 feel free to join the effort.

phyllisstein commented 6 years ago

Neat, thanks! I'll look through that PR---the spirit is willing, as far as helping to refine it, but the schedule is weak.