search

MatAtBread / fast-async

605 stars 21 forks source link

[Bug] 6.3.2 - Error: Cannot find module '@babel/helper-module-imports' #53

Closed le0nik closed 6 years ago

le0nik commented 6 years ago

@babel/helper-module-imports is being used in plugin.js but is not present in package.json's dependencies.

Error: Cannot find module '@babel/helper-module-imports'
    at Function.Module._resolveFilename (module.js:547:15)
    at Function.Module._load (module.js:474:25)
    at Module.require (module.js:596:17)
    at require (internal/module.js:11:18)
    at module.exports (*****/fast-async/plugin.js:10:25)
SeeThruHead commented 6 years ago

also seeing this fast-async/plugin.js still requires that file.

rjharmon commented 6 years ago

this can also affect users of neutrino's 'web' and 'react' presets.

jzaefferer commented 6 years ago

Looks like the dependency was removed here: https://github.com/MatAtBread/fast-async/commit/ad8383f38ed1ff6c939f2bdbcca48565dccbdd5d - its unclear though why it was removed without any other changes.

For now 6.3.1 is still working fine.

eliperelman commented 6 years ago

@rjharmon I have shipped Neutrino v8.2.2 to pin this version of fast-async mentioned by @jzaefferer.

trusktr commented 6 years ago

I came to open the same error, but then I saw this issue.

I depend on fast-async ^6.3.0, and the new 6.3.2 is breaking my project with

    Cannot find module '@babel/helper-module-imports'

I'll just change from depending on ^6.3.0 to locking it to 6.3.1 for now.

matAtWork commented 6 years ago

Apologies - I managed to mess up separating babel-7 beta dependancies from v6.

v6.3.4 published with no v7-beta dependencies. v7.01.1 published for use with babel-7-beta.

Please re-open if this update does not fix the issue in your configuration.