search

MatMaul / pynetgear

Python library to control Netgear wireless routers through the SOAP-api.
MIT License
238 stars 75 forks source link

Don't log when entry_count is too small #136

Closed markruys closed 1 year ago

markruys commented 1 year ago

In router.py, get_attached_devices(), the list of attached devices it retrieved using a SOAP call. The returned object contains a list of which the first entry is supposed to contain the length of this list (minus 1). At least for the Nighthawk MR60, this number is often too low, resulting in a lot of log entries like:

Number of devices should be: 17 but is: 18

As this number is not actually being used in get_attached_devices(), it is of no harm to suppress this log message in these cases. Otherwise it clutters the log with harmless warnings which have no actual meaning.

starkillerOG commented 1 year ago

Thanks for the PR @markruys Seems safe to ignore this indeed.