MatMechLab / AsFem

Advanced Simulation kit based on Finite Element Method (AsFem)
https://matmechlab.github.io/AsFem
GNU General Public License v3.0
180 stars 53 forks source link

State of the field in JOSS paper #64

Closed mscroggs closed 2 years ago

mscroggs commented 2 years ago

There is not very much discussion of how AsFem compares to other finite element libraries in the JOSS paper. Libraries that you could mention include:

vijaysm commented 2 years ago

I'd like to second this comment as a reviewer. There are a lot of very successful and tested, general-purpose FEM libraries out there. I fail to see a proper motivation in the JOSS paper on why there was a need to create a new one, instead of using the capabilities in the ones that @mscroggs has listed above. I'd probably also add libMesh and MoFEM to that list as well given the wide variety of applications where they have been used.

yangbai90 commented 2 years ago

Dear @mscroggs and @vijaysm , thanks for the comments, I have added the statement for the comparsion.

vijaysm commented 2 years ago

The manuscript reads much better now in the statement of need section.