MatMoul
commented
5 years ago Thanks for the PR.
Some issues found :
- I can't test the changes, the complement menu isn't added.
- lightdm-gtk-greeter, not tested but I'm pretty sure that you don't need to edit /etc/lightdm/lightdm.conf, Deepin theme is set without this.
- gvfs and udisk2 is allready installed by dependencies of deepin-daemon.
- gvfs-afc why this one and not the other? gvfs dependencies can be provided but need somme infos in the second field of the menu and perhaps set to off.
- Why adding network-manager-applet and nm-connection-editor? Deepin has it's own icon and setting UI.
I suggest you to work on the develop branch (https://github.com/MatMoul/archdi-pkg/blob/master/CONTRIBUTING.md)
And it would be nice to test the changes befor submitting a PR.
For this you can use archdi -t kassane patch-2
lightdm config; Networking Manager (Gnome) added