MatMoul / g810-led

Linux led controller for Logitech G213, G410, G413, G512, G513, G610, G810, g815, G910 and GPRO Keyboards
GNU General Public License v3.0
1.39k stars 184 forks source link

Left Alt is Green? #81

Closed Krutonium closed 7 years ago

Krutonium commented 7 years ago
g logo 000096       # Blue
g indicators ffffff # White
g multimedia 009600 # Green
g fkeys ff7700      # Orange
g modifiers ff7700  # Orange
g arrows 0000ff     # Red
g numeric 00ff00    # Green
g functions ffffff  # White
g keys ff00ff       # Purple
g gkeys ffffff      # White
k tilde ff0000      # Red
k W 0000ff          # Blue {
k A 0000ff
k S 0000ff
k D 0000ff          # }
k 1 ff0000          # Red {
k 2 ff0000
k 3 ff0000
k 4 ff0000
k 5 ff0000
k 6 ff0000
k 7 ff0000
k 8 ff0000
k 9 ff0000
k 0 ff0000          # }
c                   # Commit changes

This is the profile I am using right now. It all works (mostly) correctly - somtimes some keys don't change (my F Keys didn't turn on last reboot), but my left alt is consistently green. Any ideas what's up, or is this a bug in the software?

greenalt

G810.

Krutonium commented 7 years ago

Temp Fix: k alt_left ff7700

(About the picture - it's out of focus on purpose to make the colours show better)

MatMoul commented 7 years ago

Very strange, do you use the last version?

Krutonium commented 7 years ago

Yep, in fact, I am using the Arch (AUR) g810-led-git package - which is build from the repo.

Also my F keys are not lighting up consistently at all, in fact I need to turn them on after basically every reboot.

Specifically, https://aur.archlinux.org/packages/g810-led-git/

MatMoul commented 7 years ago

At this time, I can not reproduce, need more investigation... I try to test your profile in the next few days

MatMoul commented 7 years ago

I also encounter some problem with your profile. Now, I only have to search :(

MatMoul commented 7 years ago

After small tests, I suggest to add a commit (c) after line 10 (g gkeys ffffff # White). Set all group, commit, set keys and commit. If it work, I need to update code for handle this case.

Krutonium commented 7 years ago

Okay, giving this a shot.

Krutonium commented 7 years ago

My F keys still do not light up by default, and now my menu key (the key to the right of the right Windows key) has not lit up either.

The Ctrl key is fine though.

Krutonium commented 7 years ago

Current Profile as of now:

# Sample profile by groups keys

g logo 000096       # Blue
g indicators ffffff # White
g multimedia 009600 # Green
g fkeys ff7700      # Orange
g modifiers ff7700  # Orange
g arrows 0000ff     # Red
g numeric 00ff00    # Green
g functions ffffff  # White
g keys ff00ff       # Purple
g gkeys ffffff      # White
c                   # Commit
k tilde ff0000      # Red
k W 0000ff          # Blue {
k A 0000ff
k S 0000ff
k D 0000ff          # }
k 1 ff0000          # Red {
k 2 ff0000
k 3 ff0000
k 4 ff0000
k 5 ff0000
k 6 ff0000
k 7 ff0000
k 8 ff0000
k 9 ff0000
k 0 ff0000          # }
# k alt_left ff7700   # BUG!!! Has to be manually set!
c                   # Commit changes
MatMoul commented 7 years ago

No luck... You can try temporarily with libusb. (reinstall the package and edit the PKGBUIL) Concerning your profile, it is correct for me. You can also remove the intermediate commit (c) that I suggested, it is useless. I investigate...

MatMoul commented 7 years ago

I have pushed a new branch named "bug_sometime_wrong_key_color" that contain a fix. Can you test ?

Krutonium commented 7 years ago

Will give that a shot

Krutonium commented 7 years ago

Okay, so using that branch without rebooting (Installing some stuff that takes a while, will update afterwards) Appears to have worked, except that my fkeys remain turned off for some reason.

(built the binary and replaced the one that was installed by my package manager, so it should Just Work TM)

Edit: Post Reboot, Everything except the F keys seems correct!

MatMoul commented 7 years ago

fkeys work well for me... Try to unplug and replug your keyboard.

Krutonium commented 7 years ago

Nope, It visibly reset but didn't correct the F keys.

Running g810-led -g fkeys ff0000 does set the keys Red, but it doesn't work when it's part of the profile - even post boot piping it in.

[krutonium@krutonium-desktop ~]$ g810-led -g fkeys ff0000                 # Works
[krutonium@krutonium-desktop ~]$ g810-led -pp < /etc/g810-led/profile     # Does not work
MatMoul commented 7 years ago

Just to be sure, when you have installed the branch "bug_sometime_wrong_key_color" you have only replaced the line 19 in PKGBUILD with : source=("git://github.com/MatMoul/${_appname}.git#branch=bug_sometime_wrong_key_color")

Krutonium commented 7 years ago

I didn't use the pkgbuild, I did it manually

[krutonium@krutonium-desktop g810-led]$ git status
On branch bug_sometime_wrong_key_color
Your branch is ahead of 'origin/bug_sometime_wrong_key_color' by 1 commit.
  (use "git push" to publish your local commits)
nothing to commit, working tree clean
[krutonium@krutonium-desktop g810-led]$

I ran make bin and copied the resulting executable to /usr/bin/g810-led

MatMoul commented 7 years ago

And what happens when you make a g810-led -k f1 ff0000

Krutonium commented 7 years ago

That also worked.

MatMoul commented 7 years ago

Your build method is ok But is it normal that your branch is ahead of ... by 1 commit ? And what appens when you make a g810-led g fkeys ff7700

Krutonium commented 7 years ago

Honestly I don't know why it says that, I did a git reset --hard and it still gives me that message.

[krutonium@krutonium-desktop g810-led]$ g810-led g fkeys ff7700

Outputs usage/help.

MatMoul commented 7 years ago

sorry... g810-led -g fkeys ff7700

Krutonium commented 7 years ago

Yep, that worked correctly.

MatMoul commented 7 years ago

Very strange.... the -g fkeys is the same function that is used in profile file. No idea for now. I will make a new release with the last changes and we will investigate from this new base

Krutonium commented 7 years ago

Okay. Should I make a new issue for the F keys?

MatMoul commented 7 years ago

Yes it will be good

Krutonium commented 7 years ago

Will do.

MatMoul commented 7 years ago

Thank for your work, you can make a PR with your profile in sample... It's a good profile for debug the code

Krutonium commented 7 years ago

Sure.