MatMoul / quickdial-webext

QuickDial : WebExt Dial page for Firefox
Mozilla Public License 2.0
52 stars 15 forks source link

Very strange glitch #110

Open berlihingen opened 6 years ago

berlihingen commented 6 years ago

Updated to 63, now at start pinned tabs become overwritten by the new Quick Dial tab. It's not like a lost session - tab history shows pinned url next to QD... Any ideas?

P.S. Found tmp workaround: if "browser.sessionstore.restore_pinned_tabs_on_demand", true - new tab not forced.

P.P.S. It turns out, Mozilla made a lot of unannounced changes in javascript handling, so I tried to disable one: browser.urlbar.filter.javascript and also switched off pinned tabs loading on demand. Result: on browser restart, pinned documents were replaced by Quick Dial home (again) but after that immediately closed automatically. What a circus!

oleg-sgh commented 6 years ago

Similar problem in firefox 63. When you restart Firefox, the active tab becomes the tab Quick Dial. Video https://cloud.mail.ru/public/5hKN/gaNMHNp5f

MatMoul commented 6 years ago

I never tested with pinned page... I've added a workaround solution to prevent white page when you open the first FF window with QD as start page, this is a side effect... I'll try to investigate for this

berlihingen commented 6 years ago

It seems I found a more elegant solution: Mozilla changed the pref extensions.webextensions.background-delayed-startup from falseto true- just switch it back. Works for me, anyone can confirm?

sbstn87 commented 6 years ago

It seems I found a more elegant solution: Mozilla changed the pref extensions.webextensions.background-delayed-startup from falseto true- just switch it back. Works for me, anyone can confirm?

OK, I can confirm that this solution works (Firefox 63.0 64bit under Windows 10).

oleg-sgh commented 6 years ago

It works, but it is not a solution. This is a crutch. You can simply install version 0.1.15.

berlihingen commented 6 years ago

You can simply install version 0.1.15.

I do if you know a good reason to keep delayed-startup true?

oleg-sgh commented 6 years ago

I dont know. I myself asked to correct the replacement of the open page, on the CD, when restoring the session. Video https://cloud.mail.ru/public/5hKN/gaNMHNp5f

Echoloc8 commented 6 years ago

I also have this issue, but it appears not to be related to pinning, as I have no pinned tabs. Ubuntu 16.04, Firefox 63, QuickDial 0.1.17. I have several (between 8 and 12) windows with several tabs each in my session, and each window's active tab is replaced by Quick Dial on Firefox startup or restart. Each of the Quick Dial tabs has an active Back button, and if I press it I get the page back, but it's very annoying. Is the only fix really to unset the delayed-startup flag or go back to 0.1.15?

zokocx commented 6 years ago

Same issues, Win 10 FF 63 64-bit, I tried switching delayed-startup to false, previous was true and problem still express, not allways but there is no clear pattern.

I degraded to 0.1.15 to see if still will happens.

Echoloc8 commented 6 years ago

Switched the delayed-startup flag back to false, barely affected the issue. Is there a way to downgrade without building from source? I can, but would rather not.

berlihingen commented 6 years ago

a way to downgrade

https://addons.mozilla.org/en-US/firefox/addon/quick-dial/versions/

Echoloc8 commented 6 years ago

Thank you!

MatMoul commented 5 years ago

Seem the same issue as #113 but this issue has some infos... I leave it open

MatMoul commented 5 years ago

I've pushed a new version, try to update your extentions... I've added a parameter in QD settings that named "Startup timeout" You can set it to 0 to disable the feature, but you may encounter a blank page for QD as startpage. Or increase the value (in ms) and adjust it to your system.

berlihingen commented 5 years ago

It looks this helps to avoid blank new tab at browser start, but does nothing for restored/pinned tabs - still becomes overwritten by QD, whatever "timeout" settings.

MatMoul commented 5 years ago

Very strange for the restored/pinned tabs... I've difficulty to reproduce it because I clear all my data when closing FF and restore/pinned tabs doesn't work in this case... I'll try to make a profil for this but need some time due to the end of hollydays...

MatMoul commented 5 years ago

Just tested on a new profile, my 2 pinned tabs was restored corectly... Need more investigation