MatMoul / quickdial-webext

QuickDial : WebExt Dial page for Firefox
Mozilla Public License 2.0
51 stars 14 forks source link

Quick Dial menu does not work on FF 84/85 #162

Closed kasatikoff closed 3 years ago

kasatikoff commented 3 years ago

Quick Dial menu does not work on FF 84/85

Menu block is empty and not hidden

FF-85_QD

Shne commented 3 years ago

The reason for the breakage is that they have removed support for menuitem in Firefox 85: https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/85#Removals_2 The reason is that it is deprecated and will be removed: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/menuitem But for now it is hidden behind a flag: https://bugzilla.mozilla.org/show_bug.cgi?id=1680596 https://groups.google.com/g/mozilla.dev.platform/c/tc11BCenm2c?pli=1

So you can as a temporary measure re-enable it by setting the dom.menuitem.enabled flag to true in about:config.

In the longer run, this plugin should be updated to not use menuitem and related features, or its users will have to find an alternative.

kasatikoff commented 3 years ago

Thank you, that solved the problem

MatMoul commented 3 years ago

looking to fix it... Give me some days...

MatMoul commented 3 years ago

Hello, You can try to force update your addons and reset dom.menuitem.enabled flag. I've rewrited the context menu with the limitations of the current API. Now all is grouped in the child menu "Quick Dial"

ghost commented 3 years ago

Nice shot! Good job!