MatTheCat / HtmlCompressorBundle

Symfony2 bundle which allow to minify cacheable HTML and XML responses using htmlcompressor.
MIT License
11 stars 4 forks source link

update symfony required version #3

Closed vihuvac closed 8 years ago

vihuvac commented 8 years ago

Hello @MatTheCat how are you?

Is there any way to update the _symfony required version_ in order to make it work under _symfony 2_ and _symfony 3_? It'd look like:

...
"require": {
    "php": ">=5.3.0",
    "symfony/symfony": "~2|~3"
},
...

I am going to be waiting for updates about it.

Thanks a lot beforehand!

MatTheCat commented 8 years ago

Hi!

I don't think I'll update this bundle. As you saw too it is a wrong approach of the HTML minification problem.

I wrote a twig extension instead (see http://www.matthecat.com/minifier-votre-html-avec-twig/).

vihuvac commented 8 years ago

Hi @MatTheCat,

This bundle is working fine for me under _symfony 2.x_ but I cannot keep using it in _symfony 3_ due to the required framework version inside the _composer.json_ file:

...
"symfony/symfony": "2.*"
...

Regarding to the missing file compiler.jar I can add it!

MatTheCat commented 8 years ago

You shouldn't be using this bundle whichever the Symfony version. As I said it implements a wrong approach and I provided a better one, so I won't update it.

If you want to keep the overhead of a Java process on every request feel free to update your fork.

vihuvac commented 8 years ago

Oh ok ok, I'll take a look at the new twig extension.

Thank you very much.

:+1: