MatadorProBr / revanced-extended-magisk-module

Extensive ReVanced Extended builder. Builds both modules and APKs. Updated hourly.
https://t.me/rvxc_magisk
GNU General Public License v3.0
122 stars 25 forks source link

Could not download rv prebuilts for YT-Advanced #26

Closed Mylaur5 closed 2 months ago

Mylaur5 commented 2 months ago

I have the following error message when attempting to use the YT-Advanced source:

[+] Getting prebuilts (YT-Advanced)
2024-04-30 21:12:50 URL:https://api.github.com/repos/inotia00/revanced-cli/releases/latest [3913/3913] -> "-" [1]
https://api.github.com/repos/YT-Advanced/revanced-integrations/releases/latest:
2024-04-30 21:12:50 ERROR 404: Not Found.
[-] ABORT: could not download rv prebuilts
Error: utils.sh [-] ABORT: could not download rv prebuilts

Error: Process completed with exit code 1.

I have no idea what I'm doing it wrong, could you point me to a potential solution/explanation? I have put YT-Advanced as the source for patches. AFAIK it should be working since manual patching does work.

Mylaur5 commented 2 months ago

Alright, I managed to figure out some stuff.

Using the RVMM config gen, just inputting YT-Advanced/ReX-patches is not enough, as the config will put YT-Advanced/Revanced-integrations automatically, but this is wrong, as the repository is called YT-Advanced/ReX-integrations.

So you have to edit config.toml accordingly.

I also managed to edit options.toml to include Revancify red which was my objective. However I can't seem to have Revancify red icons in the revanced magisk modules, only the apk ones (which I don't use). I suspect that using the original package name doesn't work for custom icons which is a bummer...

The build works as expected now but also fails to build Reddit.