search

Matatika / tap-google-sheets

tap-google-sheets, singer tap built with the Meltano SDK
GNU Affero General Public License v3.0
2 stars 9 forks source link

added multiple sheets feature #10

Closed jlloyd-widen closed 7 months ago

jlloyd-widen commented 8 months ago

This PR partially addresses Issue #4. Allows for providing an array of sheets to extract. I kept the pre-existing config for backwards compatibility but using the new sheets config option will override anything in the original set of config properties.

I did not test this with all the loaders described in the readme, jsonl only.

ReubenFrankel commented 8 months ago

Hi @jlloyd-widen, thanks for this PR. Hope to review it soon, but looks good at first glance. :slightly_smiling_face:

ReubenFrankel commented 7 months ago

Hi, sorry for the slow reply @jlloyd-widen. We will probably get this out later this week along with some other changes.

I fixed a small issue with get_sheet_name missing the stream_config positional argument, which I hit because I didn't have base-level config for output_name set (n.b. #11 corrected stream_name to output_name). There are also some minor spelling mistakes in the README, but I'll correct those closer to merge (if you want to fix them, go ahead). Otherwise, pretty much ready to go - thanks! :+1:

ReubenFrankel commented 7 months ago

Thanks @jlloyd-widen :+1: