fix: unify occurrences of output_name and stream_name

Matatika / tap-google-sheets

tap-google-sheets, singer tap built with the Meltano SDK

GNU Affero General Public License v3.0

2 stars 9 forks source link

fix: unify occurrences of output_name and stream_name #12

Closed srpwnd closed 7 months ago

srpwnd commented 7 months ago

:memo: Changelog

[x] unify output_name and stream_name
[x] update README to reflect changes

:link: Links

resolves #11

I opted for output_name in this case since it is what was in the config definition (and therefore also in Meltano Hub docs). I also feel like it is more self-explanatory in what it does.

DanielPDWalker commented 7 months ago

Hey, all looks good, and thanks for the PR.

Gonna merge this in then make a quick change to the test for this setting but your changes are in now. We will likely try to get a few more PRs/issues finished and in this week, and will get a new pinned release out soon with your change in it.