search

Matatika / tap-google-sheets

tap-google-sheets, singer tap built with the Meltano SDK
GNU Affero General Public License v3.0
2 stars 9 forks source link

fix: handle all whitespaces in column names #17

Closed srpwnd closed 7 months ago

srpwnd commented 7 months ago

I noticed that the tap only simply replaces spaces with underscores but with Google Sheets, there is always a possibility the column names will contain different types of white spaces as well (in my case we have bunch of newlines and I cannot change the source sheet).

I've extended the functionality to cover these cases and produce cleaner and easily machine readable column names (imagine querying a column with newline in name in SQL 🤯 ).

I've also adjusted the test case to cover more cases of whitespaces and showcase the functionality of this PR.

ReubenFrankel commented 7 months ago

Looks good - just needs a lint fix. :slightly_smiling_face:

srpwnd commented 7 months ago

@ReubenFrankel Thank you, fixed it :)

ReubenFrankel commented 7 months ago

Thanks @srpwnd! :+1: