Matatika / tap-google-sheets

tap-google-sheets, singer tap built with the Meltano SDK
GNU Affero General Public License v3.0
2 stars 9 forks source link

Unable to parse singer METRICs #18

Closed aphethean1 closed 7 months ago

aphethean1 commented 7 months ago

Background

Taps can output singer METRIC messages. These are output to stderr, while RECORD messages are output to stdout and intended to be consumed by a target. i.e. tap -> target.

Monitoring on stderr can parse these METRIC messages and turn them into useful pipeline monitoring.

Additional information

Error parsing json {:source=>"raw_metric", :raw=>"{'type': 'counter', 'metric': 'record_count', 'value': 4, 'tags': {'stream': 'import_runner_google_sheet'}}", :exception=>#<LogStash::Json::ParserError: Unexpected character (''' (code 39)): was expecting double-quote to start field name

Proposed fix

For this tap the fix is simple. Bump the SDK version to a release with this change: https://github.com/meltano/sdk/commit/9d6a48a2507900db2e13d60b329d19aeac422783

ReubenFrankel commented 7 months ago

This is an issue in our catalog, since we are currently pinned to v0.3.0 which uses SDK version 0.4.5. The current SDK version used is 0.33.0, so we should make a new release (v0.4.0) and bump the pinned version in the catalog.

ReubenFrankel commented 7 months ago

v0.4.0 release