search

Matatika / tap-googleads

0 stars 11 forks source link

Date based state? #14

Open acarter24 opened 7 months ago

acarter24 commented 7 months ago

Is there a reason this tap doesn't make use of state to avoid querying past dates repeatedly?

Currently, the campaign status current value gets overwritten to all the past dates. If state / replication key was employed, you could maintain a record of status over time.

ReubenFrankel commented 7 months ago

Hi @acarter24! Nope, no reason - just not implemented yet. I'll discuss this with the team and leave any updates here, or feel free to open a PR if you like. :slightly_smiling_face:

acarter24 commented 7 months ago

Thanks, I am also including a report which is like adgroups, but with a date segment to give historical data at the lowest grain, so I can aggregate groups up to a campaign over time. Would that be something you would be interested in? My only concern would be the volume of data generated, perhaps it can be an optional stream by default if such a thing is possible?

Edit: Just thinking about the state issue, I'm not sure this can be done without flattening the json. I can only set replication_key to be a string, no way to point at a sub-element of the of the segments object which is what I would need to do with the current structure. I'll have a think