search

Matatika / tap-googleads

0 stars 12 forks source link

update `singer_sdk` version #40

Open tobiascadee opened 3 weeks ago

tobiascadee commented 3 weeks ago

It seems like this tap has parent child logic built in that it does not use. If the singer_sdk can be updated to the latest version there is an option to override generate_child_contexts to allow for a child stream per accessible customer.

tobiascadee commented 2 weeks ago

@DanielPDWalker would this be possible? I think the only reason not to is to support python version 3.7

DanielPDWalker commented 1 week ago

Python 3.7 is end of life anyway so dropping support seems reasonable. Plus we have GitHub releases people can pin to if they need to use a version that works with 3.7.

So I don't think there is anything stopping this change.

tobiascadee commented 1 week ago

fixed in https://github.com/Matatika/tap-googleads/pull/45