Closed ReubenFrankel closed 6 months ago
Looks like ignore_no_records_for_streams
is exactly what we want.
It will warn on no records rather than completely ignore: https://github.com/meltano/sdk/blob/7e92a28b5d0142c3b83a539b49b05d8a43656e2d/singer_sdk/testing/tap_tests.py#L82-L87
From the Web API docs:
At the moment, I am manually streaming some songs on the test account in order to generate some data that the API will return. Recently, streams with a
short_term
time range started failing because I hadn't done this in a while - I imagine leaving it longer would have meantmedium_term
and evenutallylong_term
would have also failed. For the tests, it would be better to warn about no records for these streams rather than fail, as it gives a false impression of the tap being broken at a glance.Affected streams: https://github.com/Matatika/tap-spotify/blob/1568027dd73435a61650141b6f0d99867cf9bc27/tap_spotify/tap.py#L10-L15