search

MatchaIO / ServerlessTimesheet

Timsheets on the Serverless stack
1 stars 1 forks source link

Event Store table definition #30

Open RhysC opened 7 years ago

RhysC commented 7 years ago

1) range/sort index may be wrong It should probably be the timestamp as we want this sorted. ie event coming out of order would not be ideal and i dont think we have that guarantee at the moment

ie 

KeySchema:
          -
            AttributeName: id
            KeyType: HASH
          -
            AttributeName: timestamp
            KeyType: RANGE

2) we should probably explicitly define both the eventsMetadata and the event payload "columns" as a Map and not do the serialising ourselves

RhysC commented 7 years ago

This may not be as big an issue as i thought. An incremented event Id may be fine, the change has been made nonetheless in PR #32