search

MatchaRRR / pe

0 stars 0 forks source link

Unnecessary validation when adding a car #5

Open MatchaRRR opened 1 week ago

MatchaRRR commented 1 week ago

When the user adds a car, the price cannot exceed 10000, which may be not realistic enough. Perhaps giving a warning to the users rather than just blocking the input will be better?

image.png

nus-pe-bot commented 5 days ago

Team's Response

Thank you for raising this concern. However, I think there has been a misunderstanding. Just to reiterate, our application is designed to help car rental companies handle and track car rental details. Therefore, the price of the car would refer to the rental price of the car. I figured you might have mistook our app as a car dealership app that sells cars or something along those lines, and as a result interpreted the price as the selling price of the car.

According to Google, the average car rental price in Singapore is only around $120 per day. As such, after discussing with my team, we feel that setting a limit of $10000 for the car rental price is rather reasonable. Perhaps it could even be lower than $10000 too.

Next, thank you for including suggestion(s) for improvements too. To address that, as the current version of our app doesn't support editing any records directly, my team and I feel that it is better to block the input and show an error message instead. This is because for instance, suppose the user wants/needs to edit the record details, he/she needs the delete the current record and enter a new record with the correct details, which can be cumbersome. As a result, any input which is deemed invalid will be blocked off/rejected.

However, in future versions where we do implement support for editing record details, your suggestion will actually work. In that case, since users are able to edit the record details anyways, the app could just issue a warning to the users, while still treating it as a valid input rather than blocking it off entirely.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: I understand that this is just the price of the lease and I appreciate your thoughtful consideration. I think just putting a cap on that price is difficult, let's say 10001 is not allowed while 10000 is accepted, but in reality they did not make a big difference.