search

MatchbookLab / local-persist

Create named local volumes that persist in the location(s) you want
MIT License
851 stars 122 forks source link

Update to go 1.18 + update dependencies #86

Closed Carbonique closed 1 year ago

Carbonique commented 2 years ago

Hi there,

I stumbled upon your plugin last Friday, and you did a great job! I've been thinking of using it, but what held me back was that the plugin uses quite some old versions. I've made the following changes to update the plugin. None of them change the functionality

How would you feel about merging the above?

CWSpear commented 2 years ago

I would feel good about merging! Good ol' Go deps...

Anyway, it's still marked as draft and you've been making some changes. Let me know when you're ready and we can merge.

We'll need new binaries, too.

Carbonique commented 2 years ago

Cool! I think the tests still need some work, as I've added some additional error handling which needs to be tested

How would that work regarding binaries? Will you compile and upload them after the MR has been merged? Or would you need anything from me?

CWSpear commented 2 years ago

I can do it... hopefully. :)

Carbonique commented 2 years ago

Famous last words... ;) I'm happy to help whenever needed, but I think you'll manage as the compilation should not be affected by any of my changes

Carbonique commented 2 years ago

I think that its for now. Integration tests + unit tests pass. I might open another PR in the (near) future to:

But lets first see about this PR

Carbonique commented 2 years ago

Hi there,

Just a ping as I'm curious when you'll be able to check the PR @CWSpear

CWSpear commented 2 years ago

Sorry, was at a family reunion and I should have not even opened the email, cuz then when I got home, I completely forgot about it.

Anyway... why is Travis CI not cooperating? Trying to figure that out before I merge.

CWSpear commented 1 year ago

Superseded by https://github.com/MatchbookLab/local-persist/pull/88