search

MatejSloboda / Dijkstra_map_for_Godot

MIT License
78 stars 13 forks source link

Update gdnative doc #113

Closed arnaudgolfouse closed 2 years ago

arnaudgolfouse commented 2 years ago

Bring back automatic documentation and test generation ✊

arnaudgolfouse commented 2 years ago

Some hypothetical changes to this pr that may be desirable, in case there are things I failed to consider:

  1. Remove the last commit: do not move tests from Test_dijsktra.gd to lib.rs's documentation (in case automatic generation fails).
  2. Do not update the linux executable (it wasn't working properly for me so I rebuilt it).
  3. Do not mark Interface::new as pub. This doesn't change anything I think, and making it private would prevent gdnative-doc from generating its documentation 😕.

Those are just things I thought would be worth thinking about, but the current pr seems pretty good to me.

arnaudgolfouse commented 2 years ago

Also, note that some text was automatically removed from Gut.tscn.

show ``` __meta__ = { "_edit_use_anchors_": false } ```

I don't know what that was for, but everything still works so 🤷

arnaudgolfouse commented 2 years ago

Following a discussion with @astrale-sharp, I did not update the linux shared library, as this will require more thought. I opened an issue about it at #114 .

astrale-sharp commented 2 years ago

Merging this (because you're my friend)

arnaudgolfouse commented 2 years ago

❤️