MatejSloboda / Dijkstra_map_for_Godot

MIT License
77 stars 13 forks source link

Extended visualisation.tscn with c# example #125

Closed SimonasLetukas closed 1 year ago

SimonasLetukas commented 1 year ago

https://github.com/MatejSloboda/Dijkstra_map_for_Godot/issues/124 https://github.com/MatejSloboda/Dijkstra_map_for_Godot/issues/122

astrale-sharp commented 1 year ago

I don't think this should appear in the gdscript part:


export var use_c_sharp: bool = false

var gridmap 

func _ready():
    if (use_c_sharp):
               .....
SimonasLetukas commented 1 year ago

I don't think this should appear in the gdscript part:


export var use_c_sharp: bool = false

var gridmap 

func _ready():
  if (use_c_sharp):
               .....

Do you think that having two duplicated visualization scenes would be better than this checkbox approach? Keeping in mind that the whole Godot project would need to be mono-based anyway.

astrale-sharp commented 1 year ago

No, you're right, let's use the checkbox approach !

SimonasLetukas commented 1 year ago

Thanks for the comments! I'll update the PR and then test all the remaining endpoints sometime this week and mark this as non-WIP

SimonasLetukas commented 1 year ago

There we go, I also went through the endpoints and tested them manually, seems to be working as expected. My only worry is if the new library version would work for non-mono Godot projects? In theory the .gdns file hasn't changed so it should work the same, however the demo project was changed to mono and I'm unsure of the impact here.

astrale-sharp commented 1 year ago

If you could test it with a non mono godot version that would be amazing, otherwise, it'll have to wait till i come back home, the 10th this month, thanks for all your work!

SimonasLetukas commented 1 year ago

Non-mono new Godot project worked when tested with: image

I then also created a new mono Godot project to see if the C# wrapper can be picked up: image

And they both work :)

astrale-sharp commented 1 year ago

Well, I'll go with you on that one and if we missed something, we'll see by people complaining in the issues :innocent:

Thank you very much for your involvement/work!