MatejSloboda / Dijkstra_map_for_Godot

MIT License
77 stars 13 forks source link

Fix: Turn Based Example Build Fix #84

Closed SimonasLetukas closed 3 years ago

SimonasLetukas commented 3 years ago

Hello,

Currently Project Example/dependancy/turn_based is not building. I'd like to open a PR but it looks like I don't have a permission to push my branch to remote. All I did was change id to point_id in turn_based.gd lines 45 & 46.

Seems like this issue is present in 1.0 branch as well.

arnaudgolfouse commented 3 years ago

Hi !

I tried cloning the master branch and doing the change the change you described (change id to point_id in turn_based.gd lines 45 & 46), and everything worked ; are you sure you cloned the right branch ? Branches other than master might be outdated / not work.

Also, what is your os ? I think that Dijkstra_map_library/bin/windows/dijkstra_map_gd.dll is really outdated, so if you're on windows you should wait until we update it (hopefully soon), or build it yourself.

SimonasLetukas commented 3 years ago

Yes, I'm on Windows. Yeah, changing the stuff works for me as well, I was talking about pushing a PR with the fix so it could be merged to master or even 1.0 branch, as the issue is on the 1.0 branch as well. It says I don't have the permissions to push my branch with the fix and open a PR, so tough luck :D

arnaudgolfouse commented 3 years ago

Oh ok ! I don't know how familiar you are with this process so I will try to describe it precisely :

Hope this helps you !

astrale-sharp commented 3 years ago

Hey there, i don't understand the problem exactly : gdscript doesnt need compilation (it doesnt build) so what is this problem exactly? much love, Ash

SimonasLetukas commented 3 years ago

Opened PR: #86