MatejSloboda / Dijkstra_map_for_Godot

MIT License
77 stars 13 forks source link

Setup actions #85

Closed arnaudgolfouse closed 3 years ago

arnaudgolfouse commented 3 years ago

This leverage github actions to automatically build and test the library on all 3 major platforms (linux, windows and macos).

In theory the files included in this pull request are enough to make everything just work :tm: : we just need to launch the "Build shared libraries" action.

Pros

Cons

Notes

arnaudgolfouse commented 3 years ago

Note that it also may be possible to simply build locally on our machines as an alternative. However :

MatejSloboda commented 3 years ago

This is great! Thanks! I'm a little worried about the windows auto-build. GNU and MSVC compilers are compatible on paper, but often not in practice, so hopefully this won't cause issues. I will update the godot asset store entry, since the commit that is linked there now apparently has bugs.

arnaudgolfouse commented 3 years ago

Yeah, it crossed my mind as well... I tested the produced library on a windows computer and everything seems to work fine for now. I will continue to search for a way to build it directly on windows though.

MatejSloboda commented 3 years ago

If necessary, I can compile the windows binaries manually. Also, should we add 32bit targets? Also, how do I operate this thing? I'm not very well versed in github. Do I just go to the "actions->build->shared libraries-> run workflow"?

arnaudgolfouse commented 3 years ago

Yep, that's it :slightly_smiling_face: It will create a new commit, as well as a tag named after the version number chosen. You should also be asked for a description for the commit. If this is not the behavior you want, the .github/workflows/make_release.yml file can be changed.

arnaudgolfouse commented 3 years ago

I will investigate 32bit too... but later ^^