[BUG] Error Message during initialization

MaterialFoundry / LockView

Foundry VTT module: Locks the view for the purpose of using Foundry on a digital playmat, such as a horizontally mounted TV. Scales the scene so the gridsize is always displayed corresponding to a real-world size, and can block zooming and panning

15 stars 7 forks source link

[BUG] Error Message during initialization #79

Closed wickermoon closed 2 years ago

wickermoon commented 2 years ago

Setup

OS: win10
Browser: chrome
Module version: 1.5.3
Foundry version: 10.283
Gaming system & version: dnd5e 2.0.1
Any other modules enabled: yes

Describe the bug When loading a world, LockView throws several errors/exceptions. As far as I can tell, LockView works, but when trying to migrate to foundry v10 it's making migration harder and I'm pretty sure errors/exceptions shouldn't be thrown during initialization.

Screenshots

wickermoon commented 2 years ago

P.S.: I deleted several scenes during migration, which used LockView. Maybe there are still some settings for those scenes and LockView tries to apply these to a missing scene?

CDeenen commented 2 years ago

Thanks for the bug report. Does this error only appear on initialization? Could you check if the control buttons work?

sanguaire commented 2 years ago

The buttons are working. It's only during the initialization phase.

wickermoon commented 2 years ago

Yes, as far as I can see the error messages only appear during initialization. The buttons work fine.

CDeenen commented 2 years ago

I think it's trying to access something before that something is initialized. It's weird that I didn't notice it during testing. But since everything seems to be working, just ignore it for now. I'll try to get it fixed soon.

wickermoon commented 2 years ago

Okay, I fixed the bug myself and created a pull request. :) I also changed the name to id in the module.json, because it was complaining about that.

CDeenen commented 2 years ago

fixed