MaterialFoundry / LockView

Foundry VTT module: Locks the view for the purpose of using Foundry on a digital playmat, such as a horizontally mounted TV. Scales the scene so the gridsize is always displayed corresponding to a real-world size, and can block zooming and panning
15 stars 7 forks source link

High ping #97

Open Zarhog opened 1 year ago

Zarhog commented 1 year ago

hay i think lock view is stuggeling with multiple Gm accounts being on at the same time, is it perhaps making the assumption that there should only be 1 GM?

CDeenen commented 1 year ago

I have written it with the assumption that there's 1 GM, or I should say that it didn't occur to me that people would use it with multiple GMs. It doesn't surprise me that it'd cause lag. I'll see what I can do.

CDeenen commented 1 year ago

I've been trying to reproduce this, unsuccesfully. I've got 3 instances open, 2 GM and 1 player, but it's all running smoothly. Do you know if there are specific situations or settings that cause this? Could you also check if it isn't a module incompatibility (find the culprit might be useful to test that).

DrTravisProthro commented 1 year ago

I may be able to provide some insight into the cause. I run with 2 GM accounts; 1 is running on my laptop as the server host and 1 is running on my desktop that I access to run the game through. When I do this, it generates constant checks regarding the bounding box that after a few moments enter the thousands of requests and starts to consume too many resources.

If I had to guess, I believe this occurs when there are 2 GM accounts with each being run on a different machine. What I have not tested was if I downgrade the second account that isn't hosting the server to an assistant GM account if it would remedy the issue or not.

I hope this helps with recreating the issue in question as it is currently plaguing my game and I've turned off the view lock module until I can figure out a workaround.

Zarhog commented 1 year ago

ive been trying to re-produce this myself. but inorder to do so it would seem that you need 2 people whom have connections on opposite ends of the world. a bad ping between 2 Gms seems to be the cueing factor

On Mon, 22 May 2023 at 21:37, Material Foundry @.***> wrote:

I have written it with the assumption that there's 1 GM, or I should say that it didn't occur to me that people would use it with multiple GMs. It doesn't surprise me that it'd cause lag. I'll see what I can do.

— Reply to this email directly, view it on GitHub https://github.com/CDeenen/LockView/issues/97#issuecomment-1557950947, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASG2HQUPYFPXBCRFRQDNN6TXHPFAFANCNFSM6AAAAAAYK42L7I . You are receiving this because you authored the thread.Message ID: @.***>

-- Dylan McLean

Zarhog commented 1 year ago

Hello, have you managed to reproduce / fix this issue?

CDeenen commented 1 year ago

I have not found the time for it yet, unfortunately

Zarhog commented 1 year ago

hopefully you find the time, i love this module and honestly i view it as essential

On Wed, 28 Jun 2023 at 04:13, Material Foundry @.***> wrote:

I have not found the time for it yet, unfortunately

— Reply to this email directly, view it on GitHub https://github.com/CDeenen/LockView/issues/97#issuecomment-1610617332, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASG2HQRIYTTOLUIZPK4H4YDXNOOOLANCNFSM6AAAAAAYK42L7I . You are receiving this because you authored the thread.Message ID: @.***>

-- Dylan McLean

Zarhog commented 1 year ago

hello has lock view been fixed yet in V11 to account for multiple Gms?

Zarhog commented 1 year ago

yo just doing a check in, is this project still ongoing. would like to know. as i realy want to use this modual but untill its optamised for multiple Gms i cannot